Change in openvpn[release/2.6]: Add check for bind-dev in DCO options
A message that is not in the archive (sent off-list or not yet received): gerrit.1765959951000.I5d5fca3f5f7a724b4f9ec98832d3a785459f36a5@...2715...
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1447?usp=email
to review the following change.
Change subject: Add check for bind-dev in DCO options
......................................................................
Add check for bind-dev in DCO options
Change-Id: I5d5fca3f5f7a724b4f9ec98832d3a785459f36a5
---
M src/openvpn/dco.c
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/47/1447/1
src/openvpn/dco.c +6 -0
@@ -317,6 +317,12 @@ } } +if (o->bind_dev) + { +msg (msglevel,"Note: bind-dev not supported with DCO, disabling data channel offload" ); +return false; + } +#if defined(_WIN32)if (o->mode ==MODE_SERVER ) {
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1447?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: release/2.6
Gerrit-Change-Id: I5d5fca3f5f7a724b4f9ec98832d3a785459f36a5
Gerrit-Change-Number: 1447
Gerrit-PatchSet: 1
Gerrit-Owner: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1447?usp=email
to look at the new patch set (#2).
Change subject: Add check for bind-dev in DCO options
......................................................................
Add check for bind-dev in DCO options
Github: OpenVPN/openvpn#683
Change-Id: I5d5fca3f5f7a724b4f9ec98832d3a785459f36a5
---
M src/openvpn/dco.c
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/47/1447/2
src/openvpn/dco.c +6 -0
@@ -317,6 +317,12 @@ } } +if (o->bind_dev) + { +msg (msglevel,"Note: bind-dev not supported with DCO, disabling data channel offload" ); +return false; + } +#if defined(_WIN32)if (o->mode ==MODE_SERVER ) {
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1447?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: release/2.6
Gerrit-Change-Id: I5d5fca3f5f7a724b4f9ec98832d3a785459f36a5
Gerrit-Change-Number: 1447
Gerrit-PatchSet: 2
Gerrit-Owner: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Attention is currently required from: cron2, plaisthos.
ordex has posted comments on this change by cron2. ( http://gerrit.openvpn.net/c/openvpn/+/1447?usp=email )
Change subject: Add check for bind-dev in DCO options
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2:
patch looks good, but it's missing Signed-off-by
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1447?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: release/2.6
Gerrit-Change-Id: I5d5fca3f5f7a724b4f9ec98832d3a785459f36a5
Gerrit-Change-Number: 1447
Gerrit-PatchSet: 2
Gerrit-Owner: cron2 <[email protected]...>
Gerrit-Reviewer: ordex <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: cron2 <[email protected]...>
Gerrit-Comment-Date: Wed, 14 Jan 2026 14:41:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
PATCH v2 1/1 Add check for bind-dev in DCO options
In reply to a message not in the archiveFrom: Brandon Currell <[email protected]...>
Github: OpenVPN/openvpn#683
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1447
---
This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to release/2.6.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1447
This mail reflects revision 2 of this Change.
Signed-off-by line for the author was added as per our policy.
Acked-by according to Gerrit (reflected above):
Antonio Quartulli <[email protected]...>
src/openvpn/dco.c +6 -0
@@ -317,6 +317,12 @@ } } +if (o->bind_dev) + { +msg (msglevel,"Note: bind-dev not supported with DCO, disabling data channel offload" ); +return false; + } +#if defined(_WIN32)if (o->mode ==MODE_SERVER ) {
[Openvpn-devel] [PATCH applied] Re: Add check for bind-dev in DCO options
As discussed in the GH issue, we do not expect to see support for --bind-dev in 2.6.x with the old linux "out of kernel" support - so turn off DCO if --bind-dev is requested.
This patch is only appled to release/2.6, as we *do* expect to have working --bind-dev support with the "new linux in-kernel DCO" in 2.7.0 and up, so turning it off there would be the wrong thing (even if the support has not actually merged to a release kernel yet).
I have not tested this (beyond a quick compile test), but it's straight- forward enough, and Antonio as primary DCO developer has ACKed it.
I have added your signed-off-by: line to the commit, as per our coding conventions.
Your patch has been applied to the release/2.6 branch.
commit 30041d6c40c9c0b6aa5581d4570110cde61cad0e (release/2.6)
Author: Brandon Currell Date: Wed Jan 14 17:02:32 2026 +0100
Add check for bind-dev in DCO options
Signed-off-by: Gert Doering <[email protected]...>
Acked-by: Antonio Quartulli <[email protected]...>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1447
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg35260.html
Signed-off-by: Gert Doering <[email protected]...>--
kind regards,
Gert Doering
Hello ordex, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1447?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+2 by ordex
Change subject: Add check for bind-dev in DCO options
......................................................................
Add check for bind-dev in DCO options
Github: OpenVPN/openvpn#683
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1447
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg35260.html
---
M src/openvpn/dco.c
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/47/1447/3
src/openvpn/dco.c +6 -0
@@ -317,6 +317,12 @@ } } +if (o->bind_dev) + { +msg (msglevel,"Note: bind-dev not supported with DCO, disabling data channel offload" ); +return false; + } +#if defined(_WIN32)if (o->mode ==MODE_SERVER ) {
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1447?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: release/2.6
Gerrit-Change-Id: I5d5fca3f5f7a724b4f9ec98832d3a785459f36a5
Gerrit-Change-Number: 1447
Gerrit-PatchSet: 3
Gerrit-Owner: cron2 <[email protected]...>
Gerrit-Reviewer: ordex <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1447?usp=email )
Change subject: Add check for bind-dev in DCO options
......................................................................
Add check for bind-dev in DCO options
Github: OpenVPN/openvpn#683
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1447
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg35260.html
---
M src/openvpn/dco.c
1 file changed, 6 insertions(+), 0 deletions(-)
src/openvpn/dco.c +6 -0
@@ -317,6 +317,12 @@ } } +if (o->bind_dev) + { +msg (msglevel,"Note: bind-dev not supported with DCO, disabling data channel offload" ); +return false; + } +#if defined(_WIN32)if (o->mode ==MODE_SERVER ) {
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1447?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: release/2.6
Gerrit-Change-Id: I5d5fca3f5f7a724b4f9ec98832d3a785459f36a5
Gerrit-Change-Number: 1447
Gerrit-PatchSet: 3
Gerrit-Owner: cron2 <[email protected]...>
Gerrit-Reviewer: ordex <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>